chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377
Open
tlabaj wants to merge 2 commits intopatternfly:mainfrom
Open
chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377tlabaj wants to merge 2 commits intopatternfly:mainfrom
tlabaj wants to merge 2 commits intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughReplaces imports and JSX usages of ChangesIcon replacement: BarsIcon → RhUiMenuBarsIcon
Sequence Diagram(s)(omitted — change is an icon import/use swap without new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tlabaj
requested review from
a team,
lboehling,
phcox,
thatblindgeye and
wise-king-sullyman
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md (1)
10-10: Change line 10 to usedist/esmfor consistency with other imports in this file.All other icon imports in NotificationDrawer.md use
dist/esm; line 10'sdist/jsimport creates unnecessary inconsistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md` at line 10, Update the import for RhUiMenuBarsIcon to match the other icon imports by changing the module path from '@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build, i.e. import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the NotificationDrawer.md imports consistent with the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md`:
- Line 10: Update the import for RhUiMenuBarsIcon to match the other icon
imports by changing the module path from
'@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build,
i.e. import RhUiMenuBarsIcon from
'@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the
NotificationDrawer.md imports consistent with the rest of the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 32b2fb26-83c4-46db-8e06-f6152a9e50f3
📒 Files selected for processing (15)
packages/react-core/src/components/Masthead/examples/Masthead.mdpackages/react-core/src/components/Menu/examples/Menu.mdpackages/react-core/src/components/Menu/examples/MenuWithActions.tsxpackages/react-core/src/components/Menu/examples/MenuWithFavorites.tsxpackages/react-core/src/components/Page/examples/Page.mdpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsxpackages/react-core/src/demos/Masthead.mdpackages/react-core/src/demos/Nav.mdpackages/react-core/src/demos/NotificationDrawer/NotificationDrawer.mdpackages/react-core/src/demos/Page.mdpackages/react-core/src/demos/RTL/RTL.mdpackages/react-core/src/demos/Wizard/WizardDemo.mdpackages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsxpackages/react-table/src/demos/Table.md
Collaborator
|
Preview: https://pf-react-pr-12377.surge.sh A11y report: https://pf-react-pr-12377-a11y.surge.sh |
thatblindgeye
approved these changes
Apr 24, 2026
3 tasks
3 tasks
wise-king-sullyman
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: towards #12244
Summary
Replaces
BarsIconwithRhUiMenuBarsIcon(rh-ui-menu-bars-icon) in components, documentation, and the integration demo app so the menu/bars icon uses the Red Hat UI asset.Changes
bars-icontorh-ui-menu-bars-icon.BarsIconwithRhUiMenuBarsIconin affected examples and demos.Scope
MenuWithActions,MenuWithFavorites,ActionsMenuDemo, and shared doc imports in related.mdfiles (Page, Masthead, Nav, CustomMenus, NotificationDrawer, RTL, Wizard, and related demos).Table.mdshared imports.MenuDemo.tsx.Summary by CodeRabbit
Documentation
Chores
Closes #12397